Skip to content

fix(exec): include stderr in ExecError display#286

Open
daveinturkey15-byte wants to merge 1 commit into
CortexLM:mainfrom
daveinturkey15-byte:bounty-50304-exec-error-stderr
Open

fix(exec): include stderr in ExecError display#286
daveinturkey15-byte wants to merge 1 commit into
CortexLM:mainfrom
daveinturkey15-byte:bounty-50304-exec-error-stderr

Conversation

@daveinturkey15-byte
Copy link
Copy Markdown

Summary

  • Include captured stderr in ExecError display output when stderr is non-empty.
  • Keep empty stderr out of the rendered message to avoid noisy (stderr: ) suffixes.
  • Add focused unit coverage for both display behaviors.

Why

PlatformNetwork/bounty-challenge#50304 reports that ExecError::fmt silently omits the stderr field even though failed command stderr is captured on the error object. This makes displayed non-zero-exit errors much less actionable.

Verification

  • git diff --check HEAD~1..HEAD
  • Static source check confirmed the stderr render branch, empty-stderr guard, and targeted tests are present.

Note: this WSL cron environment does not have cargo/rustc, so I could not run the Rust test suite locally here. The new tests are included for CI/local Rust verification.

Closes PlatformNetwork/bounty-challenge#50304

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] ExecError::fmt Display never includes stderr field — stderr output from failed commands is silently omitted from error messages

1 participant