fix(exec): include stderr in ExecError display#286
Open
daveinturkey15-byte wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecErrordisplay output when stderr is non-empty.(stderr: )suffixes.Why
PlatformNetwork/bounty-challenge#50304 reports that
ExecError::fmtsilently omits thestderrfield even though failed command stderr is captured on the error object. This makes displayed non-zero-exit errors much less actionable.Verification
git diff --check HEAD~1..HEADNote: this WSL cron environment does not have
cargo/rustc, so I could not run the Rust test suite locally here. The new tests are included for CI/local Rust verification.Closes PlatformNetwork/bounty-challenge#50304